Skip to content

London | ITP - Jan -26 | MOHSEN ZAMANI | Sprint 1 | Wireframe to Web Code #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mohsenzamanist wants to merge 5 commits into
base: main
Choose a base branch
from
Open

London | ITP - Jan -26 | MOHSEN ZAMANI | Sprint 1 | Wireframe to Web Code #931

mohsenzamanist wants to merge 5 commits into from

Conversation

@mohsenzamanist
Copy link

@mohsenzamanist mohsenzamanist commented Jan 8, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added side menu to the wireframe
Created new page and answered following questions:

  1. What is the purpose of a README file?
  2. What is the purpose of a wireframe?
  3. What is a branch in Git?

Questions

No questions for this PR.

@netlify
Copy link

netlify bot commented Jan 8, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 78cb57a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69709078143da20007d028ae
😎 Deploy Preview https://deploy-preview-931--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Grajales-K Grajales-K added 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. labels Jan 10, 2026
@mohsenzamanist mohsenzamanist changed the title London | ITP - Jan | MOHSEN ZAMANI | Sprint 1 | Wireframe to Web Code London | ITP - Jan -26 | MOHSEN ZAMANI | Sprint 1 | Wireframe to Web Code Jan 10, 2026
@mohsenzamanist mohsenzamanist mentioned this pull request Jan 20, 2026
Open
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 20, 2026
cjyuan
cjyuan reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

You should update index.html instead of preparing a separate HTML file.

Can you apply changes to index.html and delete explain.html?

2

One of the key objectives of this exercise is, "Check a webpage against a wireframe layout"

When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. For examples,

  • The PAGE TITLE, SUBTITLE, and the footer should be centered
  • The second and the third articles should have the same width, and appear side by side beneath the first article
  • Each article should have a "READ MORE" link surrounded by a border.
  • etc.

Can you update your page so that its structure matches the layout shown in the wireframe?

Suggestion

After you have made all the changes, try asking AI for possible improvements in terms of semantic, accessibility, typo, and consistency.
It can often help us catch errors, improve consistency, and reinforce best practices.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 20, 2026
@mohsenzamanist mohsenzamanist added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 20, 2026
cjyuan
cjyuan reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page looks good; it matches the wireframe nicely.

There seem to be some unused CSS code. Can you remove them to keep the code clean?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 21, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 21, 2026

Please note that in ITP, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@mohsenzamanist
Copy link
Author

mohsenzamanist commented Jan 21, 2026

Page looks good; it matches the wireframe nicely.

There seem to be some unused CSS code. Can you remove them to keep the code clean?

Deleted unused CSS code.

@mohsenzamanist
Copy link
Author

mohsenzamanist commented Jan 21, 2026

Please note that in ITP, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.

    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.

      • You may find the suggestions in this PR Guide useful.

    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.

  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)

    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

Thank you and PR guide was read and will be taken into action.

@mohsenzamanist mohsenzamanist added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 21, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 21, 2026

Great work!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 21, 2026
@mohsenzamanist mohsenzamanist mentioned this pull request Jan 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohsenzamanist @cjyuan @Grajales-K